KASP Rule — A rule to review a PR
1 min readApr 1, 2021
Few points, we need to understand while reviewing PR(Pull Request). I follow the KASP rule.
- Review code kindly. what I mean is — We should review the code, not the person, to do that you can avoid “you/your” words. Remember, reviewing PR not only helps the writer, but you can also be benefitted from it. Leave at least one positive comment.
- Comment with accuracy. Don’t leave ambiguous comments. Your comment justifies your understanding. Revisit your comments.
- Review it slowly. Understand the business requirement first. Get to know about design patterns(SOLID, DRY, KISS). Talk to the writer if you don’t understand it. Don’t hurry my friend. Remember, there can be multiple ways(logic) to solve a problem and principles are guidelines, not rules.
- Review in parts. Try to understand code in modules, class, behavior(method). If you find difficulties on github/gitlab, open it in an editor. Sometimes you might need to read the same code again.
Thanks
Twitter